Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn if the Ruby version isn't explicitly specified in Gemfile #611

Closed
edmorley opened this issue Aug 3, 2017 · 1 comment
Closed

Warn if the Ruby version isn't explicitly specified in Gemfile #611

edmorley opened this issue Aug 3, 2017 · 1 comment

Comments

@edmorley
Copy link
Member

edmorley commented Aug 3, 2017

The heroku CLI plugin for clearing the build cache currently special-cases the directories used by the Ruby buildpack for storing Ruby version, and preserves them whilst "clearing" the cache. Ideally the plugin wouldn't do this, and instead the Ruby buildpack would warn users if they do not explicitly specify a Ruby version in their Gemfile, to avoid problems when they use review apps or pipelines.

For more info, see heroku/heroku-repo#70.

@schneems
Copy link
Contributor

schneems commented Aug 9, 2017

We do warn if Ruby version isn't explicitly set. We also provide a fallback, and to make that fallback not randomly break when we upgrade ruby versions we must record that fallback version somewhere permanent. For now that place is the poorly named "cache".

The cache is for all purposes a durable store that can be cleared/cleaned. We've re-purposed this folder to be an actual durable store by bypassing the ability to clean or clear it. This is intentional.

@schneems schneems closed this as completed Aug 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants