-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Bundler 2.4.20+ to enable ruby file: '.ruby-version'
in Gemfile
#1408
Comments
|
Thanks @dentarg 👍. Yes, I've used and liked that technique for some time too. It works well for ruby(/^ruby\s(.*)$/.match(File.read(".tool-versions"))[1].strip) |
Feature requests are the number 1 reason (after bug fixes) for us to rev the bundler version. So thanks for letting me know you want it! As an FYI In the future https://github.com/heroku/buildpacks-ruby will eventually replace this buildpack (a long way off). It pulls the bundler version from the Gemfile.lock instead of using this "blessed" system, which I would like to move away from. Timing-wise, I'm unsure when I'll be able to get this out. I'm mindful that a lot of companies have holidays coming up and a 1 in a million bug for bundler shows up pretty often for us (so I want to balance out stability, even if there's no known cause for concern). To recap: Yes, I'll upgrade for sure. No commitment on the timeline, though. |
+1 for this. We recently switched to the new DSL in Gemfile but had to revert the change until the buildpack can support it. Thanks for looking into it @schneems! |
@schneems you might want to get to this before the next Rails release? If that release will include rails/rails#49360 |
Submitted ticket #1349048 to Heroku support about this |
I've verified deployment works now (using |
We seem to still get errors when detecting rake tasks. Initially it is able to install all gems, but it fails on a later step.
|
@schneems I think this issue can be closed now |
It'd be handy for the Heroku Ruby buildpack to enable using the
ruby file: ...
option inGemfile
by supporting Bundler 2.4.20.This was introduced in Bundler 2.4.19:
Bundler 2.4.20 improved on this to support more formats, including
.tool-versions
:Changelog entry: https://github.com/rubygems/rubygems/blob/master/bundler/CHANGELOG.md#2420-september-27-2023
The text was updated successfully, but these errors were encountered: