Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Having rack gem is not a guarantee for having rackup executable (since Rack 3) #1356

Open
dentarg opened this issue Jan 2, 2023 · 2 comments

Comments

@dentarg
Copy link

dentarg commented Jan 2, 2023

Spotted this when creating #1355

def default_process_types
# let's special case thin here if we detect it
web_process = bundler.has_gem?("thin") ?
"bundle exec thin start -R config.ru -e $RACK_ENV -p ${PORT:-5000}" :
"bundle exec rackup config.ru -p ${PORT:-5000}"
super.merge({
"web" => web_process
})
end

Since Rack 3, that code needs another guard on the rackup gem: https://github.com/rack/rack/blob/v3.0.3/UPGRADE-GUIDE.md#binrackup-was-moved-to-a-separate-gem

@schneems
Copy link
Contributor

schneems commented Oct 6, 2023

Good catch. What do you think would be a good default here when there is no rackup gem? Specify no web default?

@dentarg
Copy link
Author

dentarg commented Oct 7, 2023

Sounds resonable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants