Skip to content

Commit

Permalink
Remove redundant site-packages cleanup steps (#1007)
Browse files Browse the repository at this point in the history
Since `get-pip.py` / pip will automatically detect and remove old
pip/setuptools versions if needed, so removing them manually is both not
necessary and slows down the build in the case where the pip version
changed, but setuptools remained the same.
  • Loading branch information
edmorley committed Jul 29, 2020
1 parent 2097eab commit 0027f23
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions bin/steps/python
Original file line number Diff line number Diff line change
Expand Up @@ -167,10 +167,6 @@ if [ "$FRESH_PYTHON" ] || [[ ! $(pip --version) == *${PIP_VERSION}* ]]; then

puts-step "Installing pip ${PIP_VERSION}, setuptools ${SETUPTOOLS_VERSION} and wheel ${WHEEL_VERSION}"

# Remove old installations.
rm -fr /app/.heroku/python/lib/python*/site-packages/pip-*
rm -fr /app/.heroku/python/lib/python*/site-packages/setuptools-*

/app/.heroku/python/bin/python "$GETPIP_PY" pip=="${PIP_VERSION}" "setuptools==${SETUPTOOLS_VERSION}" "wheel==${WHEEL_VERSION}" &> /dev/null
fi

Expand Down

0 comments on commit 0027f23

Please sign in to comment.