Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default Procfile if PROCFILE is not set #2

Open
dnjstrom opened this issue Mar 8, 2018 · 2 comments
Open

Use default Procfile if PROCFILE is not set #2

dnjstrom opened this issue Mar 8, 2018 · 2 comments

Comments

@dnjstrom
Copy link

dnjstrom commented Mar 8, 2018

Currently, if the PROCFILE environment variable is not set this buildpack will fail with an error. I would like to suggest that we don't fail right away but try and use the default Procfile and print a notice that we did. Only if no Procfile can be found in the root directory should we fail with an error. The PROCFILE can in this sense be regarded as an override, rather than a required definition. I believe this behavior should be a bit more user-friendly and about as easy to debug.


About my specifc use-case:

My code-base contains both a webapp and a storybook static site generator and each require their own build and run steps. Usually what I want is for the webapp to build/test/run as normal but for the storybook deploy I would like to override the build/run steps with as little changes as possible to the other deployment configuration. Adding a default PROCFILE value would allow me to leave it out everywhere but the storybook deploy.


If you feel that this seems like a good idea I'd be happy to contribute with a PR 🙂

@conor909
Copy link

What should the contents of the Procfile be? Also what should the PROCFILE var be set to? Is it the path to the Procfile? so packages/web or packages/web/Procfile ?

@apghero
Copy link
Contributor

apghero commented Sep 26, 2019

@dnjstrom This seems better from a usability standpoint, but I must say that I do really like the explicitness in the way it works, today. I assume by "default Procfile" you mean the automatically discovered process types that the ruby, python, node.js buildpacks provide? I'm not entirely sure this will work, but if you want to experiment, I'm not against merging a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants