Skip to content

Commit 9646b96

Browse files
authored
Make rails5_ci_fails_no_database tests use Heroku-18 [skip changelog] (#174)
The `rails5_ci_fails_no_database` test fixture now fails after the Heroku default stack changed from `heroku-18` to `heroku-20`, since the fixture's `Gemfile.lock` specifies Ruby 2.4.1, when the oldest Ruby on Heroku-20 is Ruby 2.5.8. As a stop-gap until the external-repo fixture is updated to use newer Ruby, the tests now explicitly use the Heroku-18 stack rather than whatever happens to be the platform default. Fixes #173.
1 parent 97a18b8 commit 9646b96

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

Diff for: spec/hatchet/ci_spec.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828

2929
it "error with bad app" do
3030
expect {
31-
Hatchet::GitApp.new("rails5_ci_fails_no_database").run_ci { }
31+
Hatchet::GitApp.new("rails5_ci_fails_no_database", stack: "heroku-18").run_ci { }
3232
}.to raise_error(/PG::ConnectionBad: could not connect to server/)
3333
end
3434

@@ -41,7 +41,7 @@
4141
@before_deploy_dir_pwd = Dir.pwd
4242
end
4343

44-
Hatchet::GitApp.new("rails5_ci_fails_no_database", allow_failure: true, before_deploy: before_deploy).run_ci do |test_run|
44+
Hatchet::GitApp.new("rails5_ci_fails_no_database", stack: "heroku-18", allow_failure: true, before_deploy: before_deploy).run_ci do |test_run|
4545
expect(test_run.status).to eq(:errored)
4646
expect(@before_deploy_dir_pwd).to eq(Dir.pwd)
4747
expect(@before_deploy_called).to be_truthy

0 commit comments

Comments
 (0)