-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Ark server to run in arbitrary namespaces #106
Comments
To do this, we should
|
@ncdc Can I work on a PR for (1) and (2)? |
Definitely, thanks!
…On Thu, Oct 12, 2017 at 4:17 AM Willem Pienaar ***@***.***> wrote:
@ncdc <https://github.com/ncdc> Can I work on a PR for (1) and (2)?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#106 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAABYpvT_7qRjJHdUCuyjwlL-b73pWv0ks5srcsugaJpZM4PmMuj>
.
|
If there’s anything that you think needs discussion before coding, feel
free to raise that here first.
…On Thu, Oct 12, 2017 at 7:11 AM Andy Goldstein ***@***.***> wrote:
Definitely, thanks!
On Thu, Oct 12, 2017 at 4:17 AM Willem Pienaar ***@***.***>
wrote:
> @ncdc <https://github.com/ncdc> Can I work on a PR for (1) and (2)?
>
> —
> You are receiving this because you were mentioned.
>
>
> Reply to this email directly, view it on GitHub
> <#106 (comment)>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/AAABYpvT_7qRjJHdUCuyjwlL-b73pWv0ks5srcsugaJpZM4PmMuj>
> .
>
|
@SleepyBrett @woop just checking in - are either of you working on this? Thanks! |
@ncdc I'm not actively working on this. Bit short on time. I'll swing back when I have more free time. |
My approach, for the server, was to inject the namespace into the server as an environment and read the environment variable, if it exists, else use the default namespace. @ncdc Can you elaborate on "Use the in-cluster namespace for the ark server" |
@ashish-amarnath yes, it's part of client-go. Let me see if I can dig up the exact code you'll need. |
@ashish-amarnath in pkg/client/client.go, replace the call to clientConfig := clientcmd.NewNonInteractiveDeferredLoadingClientConfig(
loader,
&clientcmd.ConfigOverrides{},
) That gives you a |
Currently the Ark server component assumes that it's configuration is stored in api.DefaultNamespace (heptio-ark) with no way to override. As cluster admins we put these kind of tools into a 'utils' namespace and would like to do the same for Ark.
The server component should probably assume it's configuration is stored in the namespace it's deployed in. The client would need to support a namespace flag or configuration or both.
The text was updated successfully, but these errors were encountered: