Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the non-deterministic tests #18

Open
kelvinst opened this issue Sep 4, 2017 · 2 comments
Open

Fix the non-deterministic tests #18

kelvinst opened this issue Sep 4, 2017 · 2 comments

Comments

@kelvinst
Copy link
Contributor

kelvinst commented Sep 4, 2017

So, there are some tests that randomly fail. I guess that's because they test based on time span, and sometimes the spinner does not render the quantity it was expected to.

Going deeper: the processor is busy doing something else and the AnimationServer depends on it to process the :tick message.

Any idea of what could we do to make sure this kind of feature is working?

Maybe we should not test the timing for spinners at all, only test if it prints at least one step, then any quantity of other steps, and finally the conclusion step.

@kelvinst
Copy link
Contributor Author

kelvinst commented Sep 4, 2017

It could even make the tests a little faster. 🤣

@kelvinst kelvinst changed the title Fix the no deterministic tests Fix the non-deterministic tests Sep 13, 2017
@henrik
Copy link
Owner

henrik commented Sep 29, 2017

I agree this sucks :) I think I like your idea of checking for some of the steps but maybe not requiring each and every one of them. I'll leave this ticket open and might look at it when things are less busy. Or if anyone wants to make a PR, feel free.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants