fix(bpf/ssl): first HTTPS request on the server side might not be captured #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
bug-fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a condition:
(conn_info->protocol != kProtocolUnknown && conn_info->no_trace == protocol_unknown)when report ssl data to userspace . This is for the case when protocol is already inffered in previous syscall but user space have not yet updated the conn_info.no_trace to traceable.so when conn_info.protocol is not unknown but the cause of trace state is unknown, we still trace data.