Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Introduce counters to count lost samples in bpf/events #254

Merged
merged 2 commits into from
Jan 6, 2025
Merged

feat: Introduce counters to count lost samples in bpf/events #254

merged 2 commits into from
Jan 6, 2025
+42 −0

Conversation

spencercjh
Copy link
Contributor

RESOLVE #225

@vercel Vercel
Copy link

vercel bot commented Jan 6, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kyanos ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 6, 2025 7:35am

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request labels Jan 6, 2025
@spencercjh
Copy link
Contributor Author

spencercjh commented Jan 6, 2025 •
edited
Loading

There will be a new issue about TUI changes for there counters AFTER #225 is resolved. :)

hengyoush
hengyoush reviewed Jan 6, 2025
View reviewed changes
bpf/events.go Outdated Show resolved Hide resolved
hengyoush
hengyoush approved these changes Jan 6, 2025
View reviewed changes
Copy link
Owner

@hengyoush hengyoush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 6, 2025
@hengyoush hengyoush merged commit 0fe020c into hengyoush:main Jan 6, 2025
15 checks passed
@spencercjh spencercjh deleted the feat/lost-samples-cnt branch January 6, 2025 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hengyoush hengyoush hengyoush approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check Lost Samples num when read from perf event buffer encounter EOF
2 participants
@spencercjh @hengyoush