From 4735d74502f6862ffdcd2671ba4cc084313ba10b Mon Sep 17 00:00:00 2001 From: Ziyi Chen Date: Tue, 24 Oct 2023 11:04:35 -0400 Subject: [PATCH 1/2] fix Cannot read properties of undefined (reading 'replace') --- .../nodes/vectorstores/InMemory/InMemoryVectorStore.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/components/nodes/vectorstores/InMemory/InMemoryVectorStore.ts b/packages/components/nodes/vectorstores/InMemory/InMemoryVectorStore.ts index 55a01e2b31b..fd2246c939a 100644 --- a/packages/components/nodes/vectorstores/InMemory/InMemoryVectorStore.ts +++ b/packages/components/nodes/vectorstores/InMemory/InMemoryVectorStore.ts @@ -71,7 +71,9 @@ class InMemoryVectorStore_VectorStores implements INode { const flattenDocs = docs && docs.length ? flatten(docs) : [] const finalDocs = [] for (let i = 0; i < flattenDocs.length; i += 1) { - finalDocs.push(new Document(flattenDocs[i])) + if (flattenDocs[i] !== undefined) { + finalDocs.push(new Document(flattenDocs[i])) + } } const vectorStore = await MemoryVectorStore.fromDocuments(finalDocs, embeddings) From cc3c881385c76bc926ab526c7f7bd5aea7d403a8 Mon Sep 17 00:00:00 2001 From: Ziyi Chen Date: Fri, 27 Oct 2023 19:57:01 -0400 Subject: [PATCH 2/2] should validate .pageContent --- .../nodes/vectorstores/InMemory/InMemoryVectorStore.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/components/nodes/vectorstores/InMemory/InMemoryVectorStore.ts b/packages/components/nodes/vectorstores/InMemory/InMemoryVectorStore.ts index fd2246c939a..a480ace052c 100644 --- a/packages/components/nodes/vectorstores/InMemory/InMemoryVectorStore.ts +++ b/packages/components/nodes/vectorstores/InMemory/InMemoryVectorStore.ts @@ -71,7 +71,7 @@ class InMemoryVectorStore_VectorStores implements INode { const flattenDocs = docs && docs.length ? flatten(docs) : [] const finalDocs = [] for (let i = 0; i < flattenDocs.length; i += 1) { - if (flattenDocs[i] !== undefined) { + if (flattenDocs[i] !== undefined && flattenDocs[i].pageContent !== undefined) { finalDocs.push(new Document(flattenDocs[i])) } }