Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename PackageStore::proto_path() and proto_vendor_path() to something snappier. #135

Open
xfbs opened this issue Oct 20, 2023 · 0 comments
Assignees
Labels
datamodel Changes related to the Datamodel priority::low Please dont work on this if you can contribute something with a higher priority type::idea Rough idea or proposal for buffrs type::refactoring Changing the inner-workings of buffrs type::style Related to personal or community opinions
Milestone

Comments

@xfbs
Copy link
Contributor

xfbs commented Oct 20, 2023

I still think that the "proto_path" is not related to the store, so:

proto/* -> the current package
proto/vendor/* -> the "package store"

So if we would split out the logic for accessing the first path that would be great. I think the weirdness that the vendor dir lives inside of the proto dir creates these blurry borders

@xfbs xfbs self-assigned this Oct 20, 2023
@mara-schulke mara-schulke added datamodel Changes related to the Datamodel type::style Related to personal or community opinions type::refactoring Changing the inner-workings of buffrs type::idea Rough idea or proposal for buffrs priority::low Please dont work on this if you can contribute something with a higher priority labels Oct 20, 2023
@mara-schulke mara-schulke added this to the Stabilization milestone Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datamodel Changes related to the Datamodel priority::low Please dont work on this if you can contribute something with a higher priority type::idea Rough idea or proposal for buffrs type::refactoring Changing the inner-workings of buffrs type::style Related to personal or community opinions
Projects
Status: No status
Development

No branches or pull requests

2 participants