Skip to content

Commit 556fa1b

Browse files
committed
PR: unskip TestResolvePath
Signed-off-by: Hamza El-Saawy <[email protected]>
1 parent 5ad7af4 commit 556fa1b

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

Diff for: .github/workflows/ci.yml

+5-7
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
show-progress: false
1919

2020
- name: Install go
21-
uses: actions/setup-go@v4
21+
uses: actions/setup-go@v5
2222
with:
2323
go-version: ${{ env.GO_VERSION }}
2424
cache: false
@@ -45,7 +45,7 @@ jobs:
4545
show-progress: false
4646

4747
- name: Install go
48-
uses: actions/setup-go@v4
48+
uses: actions/setup-go@v5
4949
with:
5050
go-version: ${{ env.GO_VERSION }}
5151
# don't really need to cache Go packages, since go generate doesn't require much.
@@ -91,7 +91,7 @@ jobs:
9191
show-progress: false
9292

9393
- name: Install go
94-
uses: actions/setup-go@v4
94+
uses: actions/setup-go@v5
9595
with:
9696
go-version: ${{ env.GO_VERSION }}
9797

@@ -102,10 +102,8 @@ jobs:
102102
- name: Install gotestsum
103103
run: go install gotest.tools/gotestsum@${{ env.GOTESTSUM_VERSION }}
104104

105-
# TODO: until https://github.com/golang/go/issues/64028 is backported, skip `TestResolvePath`.
106-
# Functionality is unchanged, but `filepath.EvalSymlinks` cannot handle `\\?\Volume{...}\` prefixes.
107105
- name: Test repo
108-
run: gotestsum --format standard-verbose --debug -- -gcflags=all=-d=checkptr -race -v -skip "^TestResolvePath$" ./...
106+
run: gotestsum --format standard-verbose --debug -- -gcflags=all=-d=checkptr -race -v ./...
109107

110108
# !NOTE:
111109
# Fuzzing cannot be run across multiple packages, (ie, `go -fuzz "^Fuzz" ./...` fails).
@@ -125,7 +123,7 @@ jobs:
125123
show-progress: false
126124

127125
- name: Install go
128-
uses: actions/setup-go@v4
126+
uses: actions/setup-go@v5
129127
with:
130128
go-version: ${{ env.GO_VERSION }}
131129

0 commit comments

Comments
 (0)