CrossOriginResourcePolicyOptions: why not union type for policy?

[gurdiga]

Hi! 👋🙂

The MDN docs for Cross-Origin-Resource-Policy say that it can have one of 3 values: same-site | same-origin | cross-origin — which looks a lot like a union type by the way… 😉

…and, I just wanted to ask if there is a reason for having the policy member in CrossOriginResourcePolicyOptions is of type string instead of a union type like this:

export interface CrossOriginResourcePolicyOptions {
  policy?: "same-site" | "same-origin" | "cross-origin";
}

Cheers!

[EvanHahn]

This is done in the next version of Helmet, v6. The code looks almost exactly like you're suggesting:

helmet/middlewares/cross-origin-resource-policy/index.ts

Lines 3 to 5 in 931a4fb

	export interface CrossOriginResourcePolicyOptions {
	policy?: "same-origin" | "same-site" | "cross-origin";
	}

See #370 for more.

I'm going to close this because I think this answers your question, but let me know if that's wrong and I can reopen.