-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate chart-testing formula to homebrew/core #247
Migrate chart-testing formula to homebrew/core #247
Conversation
Signed-off-by: Alexander Zigelski <[email protected]>
I don't think my change caused the build to fail. Can someone kick the CI server to retry? Maybe @scottrigby ? |
I don't see any advantage here. I'd rather keep things under our control. Why would it make sense to rely on a CI job in one of your private repos? |
the advantages are:
Of course, you don't want to rely on a CI job in one of my public repos but you can rely on the active Homebrew community to keep your formula in the best shape possible while you worry about the If you still want to keep everything under your own belt feel free to close this PR. |
@crunchtime-ali Thanks for clarifying and thanks for your effort. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned on keybase, I think this is a win all around 👍
We only track the top 200 formulae for now, which doesn’t include chart-testing. However, we do track two of your dependencies, As soon as you see both |
Signed-off-by: Alexander Zigelski [email protected]
Congratulations! 🎉 The formula
chart-testing
has been migrated tohomebrew-core
🍺This means that the
homebrew
community will co-author the formula and the formula is even easier to install (viabrew install chart-testing
).What this PR does:
This PR changes the instructions on how to install
chart-testing
on macOS. It also removes the tap configuration fromgoreleaser
which prevents your own tap to be updated. The formula will be updated by the Homebrew community (e.g. automatically viabrew bump-formula-pr chart-testing $VERSION
which is triggered automatically by GitLab CI action in one of my private repos).If you plan to automate
chart-testing
GitHub releases we can also include a GitHub action that automatically create a PR againsthomebrew-core
. You can see an example on how to accomplish this in therelease.yaml
here https://github.com/argoproj/argo-cd/pull/3979/filesHere is the accompanying PR in your tap repo: helm/homebrew-tap#1