Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate chart-testing formula to homebrew/core #247

Merged
merged 1 commit into from
Aug 30, 2020
Merged

Migrate chart-testing formula to homebrew/core #247

merged 1 commit into from
Aug 30, 2020

Conversation

crunchtime-ali
Copy link
Contributor

Signed-off-by: Alexander Zigelski [email protected]

Congratulations! 🎉 The formula chart-testing has been migrated to homebrew-core 🍺
This means that the homebrew community will co-author the formula and the formula is even easier to install (via brew install chart-testing).

What this PR does:

This PR changes the instructions on how to install chart-testing on macOS. It also removes the tap configuration from goreleaser which prevents your own tap to be updated. The formula will be updated by the Homebrew community (e.g. automatically via brew bump-formula-pr chart-testing $VERSION which is triggered automatically by GitLab CI action in one of my private repos).
If you plan to automate chart-testing GitHub releases we can also include a GitHub action that automatically create a PR against homebrew-core. You can see an example on how to accomplish this in the release.yaml here https://github.com/argoproj/argo-cd/pull/3979/files

Here is the accompanying PR in your tap repo: helm/homebrew-tap#1

@crunchtime-ali
Copy link
Contributor Author

I don't think my change caused the build to fail. Can someone kick the CI server to retry? Maybe @scottrigby ?

@unguiculus
Copy link
Member

I don't see any advantage here. I'd rather keep things under our control. Why would it make sense to rely on a CI job in one of your private repos?

@crunchtime-ali
Copy link
Contributor Author

I don't see any advantage here. I'd rather keep things under our control. Why would it make sense to rely on a CI job in one of your private repos?

the advantages are:

  • the binaries are bottled for the current macOS version and the former two
  • the community makes sure that the formula and chart-testing itself works with the new architecture (welcome Apple Silicone) without you lifting a finger (see macOS 11 Big Sur compatibility on Apple Silicon Homebrew/brew#7857)
  • you can check out installation analytics for the formula if you are interested in it

Of course, you don't want to rely on a CI job in one of my public repos but you can rely on the active Homebrew community to keep your formula in the best shape possible while you worry about the chart-testing project itself.
Since chart-testing releases are not automated there was no point in adding a CI job to this repo. If you are interested in switching the build and release process to GitHub actions I could prepare another PR independent of this one.

If you still want to keep everything under your own belt feel free to close this PR.

@unguiculus
Copy link
Member

unguiculus commented Aug 9, 2020

@crunchtime-ali Thanks for clarifying and thanks for your effort.

Copy link
Member

@scottrigby scottrigby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned on keybase, I think this is a win all around 👍

@claui
Copy link

claui commented Aug 30, 2020

  • the community makes sure that the formula and chart-testing itself works with the new architecture (welcome Apple Silicone)

We only track the top 200 formulae for now, which doesn’t include chart-testing. However, we do track two of your dependencies, go and helm.

As soon as you see both go and helm listed 🥉 (or better) on Homebrew/brew#7857, chances are chart-testing is going to work just fine, too.

@scottrigby scottrigby merged commit 49f3a5e into helm:master Aug 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants