-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Homebrew installer #244
Conversation
The Homebrew formula installs the config files to Homebrew's etc directory, so we add that to the search locations for config files. Signed-off-by: Reinhard Nägele <[email protected]>
LGTM 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 Just some side note comments
description: Testing and linting Helm charts | ||
install: | | ||
bin.install "ct" | ||
etc.install "etc" => "ct" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had to look up etc.install
https://www.rubydoc.info/github/Homebrew/brew/Formula:etc interesting!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Me too. Took me a while to figure out how to do it. My first attempt was to copy it to $HOME/.ct
, but it doesn't seem to be possible to add stuff to a user's home directory. Homebrew changes the complete environment during the installation.
@@ -56,3 +56,18 @@ dockers: | |||
extra_files: | |||
- etc/chart_schema.yaml | |||
- etc/lintconf.yaml | |||
brews: | |||
- github: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
quick note while I was looking… when we upgrade goreleaser to v0.139.0
we'll want to change this to tap
https://goreleaser.com/deprecations/#brewsgithub but 👌 for now!
@@ -34,16 +34,13 @@ Unpack the `ct` binary, add it to your PATH, and you are good to go! | |||
A Docker image is available at `quay.io/helmpack/chart-testing` with list of | |||
available tags [here](https://quay.io/repository/helmpack/chart-testing?tab=tags). | |||
|
|||
### From Source | |||
### Homebrew |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad for this change. People seem to keep getting confused at the from source options
The Homebrew formula installs the config files to Homebrew's
etc directory, so we add that to the search locations for config files.
Signed-off-by: Reinhard Nägele [email protected]