Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable installing with go get #110

Merged
merged 1 commit into from
Feb 18, 2019
Merged

Conversation

jlegrone
Copy link
Member

What this PR does / why we need it:

This moves main.go to a directory that matches the name of our installed binary, as recommended by the cobra docs:
https://github.com/spf13/cobra/blob/7547e83b2d85fd1893c7d76916f67689d761fecb/README.md#getting-started

This will make it possible to install ct with the command go get github.com/helm/chart-testing/ct if merged to master.

Which issue this PR fixes

Closes #109

Special notes for your reviewer:

Since go get doesn't allow specifying a branch, for testing purposes I modified imports on the master branch of my fork. You can run go get github.com/jlegrone/chart-testing/ct to test go get behavior.

Signed-off-by: Jacob LeGrone <[email protected]>
@rimusz
Copy link
Contributor

rimusz commented Feb 16, 2019

nice one

@cpanato cpanato closed this Feb 18, 2019
@cpanato cpanato reopened this Feb 18, 2019
@helm-bot helm-bot added size/S and removed size/S labels Feb 18, 2019
@jlegrone jlegrone closed this Feb 18, 2019
@jlegrone jlegrone reopened this Feb 18, 2019
@helm-bot helm-bot added size/S and removed size/S labels Feb 18, 2019
@unguiculus unguiculus merged commit a1528a4 into helm:master Feb 18, 2019
@jlegrone jlegrone deleted the feature/go-get branch February 18, 2019 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support go get for installation
5 participants