Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExcludedCharts does not work with multi-level ChartDirs #311

Closed
stawii opened this issue Dec 17, 2020 · 0 comments · Fixed by #312
Closed

ExcludedCharts does not work with multi-level ChartDirs #311

stawii opened this issue Dec 17, 2020 · 0 comments · Fixed by #312

Comments

@stawii
Copy link

stawii commented Dec 17, 2020

Is this a BUG REPORT or FEATURE REQUEST? (choose one): BUG REPORT

Version of Helm and Kubernetes:

N/A

What happened:

ExcludedCharts does not work when ChartDirs contains path with more than one level: ie. charts/apps or charts/my/path/is/longer/than/yours.

What you expected to happen:

Chart is excluded correctly.

How to reproduce it (as minimally and precisely as possible):

chart-dirs:
  - charts/apps

excluded-charts: # neither of those works
  - charts/apps/chart-name
  - chart-name

Anything else we need to know:

I guess it is this line

if len(pathElements) < 2 || util.StringSliceContains(cfg.ExcludedCharts, pathElements[1]) {
- the pathElements is [charts, apps, chart-name], so chart name is 2 not 1 in this example. This will be different if path has more levels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant