Improve error logging (#91)

Signed-off-by: Reinhard Nägele <[email protected]>

Author: unguiculus

app/cmd/install.go

@@ -76,14 +76,14 @@ func install(cmd *cobra.Command, args []string) {
 
 	configuration, err := config.LoadConfiguration(cfgFile, cmd, bindRootFlags, bindInstallFlags)
 	if err != nil {
-		fmt.Println(err)
+		fmt.Printf("Error loading configuration: %s\n", err)
 		os.Exit(1)
 	}
 
 	testing := chart.NewTesting(*configuration)
 	results, err := testing.InstallCharts()
 	if err != nil {
-		fmt.Println("Error installing charts:", err)
+		fmt.Printf("Error installing charts: %s\n", err)
 	} else {
 		fmt.Println("All charts installed successfully")
 	}

app/cmd/lint.go

@@ -78,14 +78,14 @@ func lint(cmd *cobra.Command, args []string) {
 
 	configuration, err := config.LoadConfiguration(cfgFile, cmd, bindRootFlags, bindLintFlags)
 	if err != nil {
-		fmt.Println(err)
+		fmt.Printf("Error loading configuration: %s\n", err)
 		os.Exit(1)
 	}
 
 	testing := chart.NewTesting(*configuration)
 	results, err := testing.LintCharts()
 	if err != nil {
-		fmt.Println("Error linting charts")
+		fmt.Printf("Error linting charts: %s\n", err)
 	} else {
 		fmt.Println("All charts linted successfully")
 	}

app/cmd/lintAndInstall.go

@@ -45,14 +45,14 @@ func lintAndInstall(cmd *cobra.Command, args []string) {
 
 	configuration, err := config.LoadConfiguration(cfgFile, cmd, bindRootFlags, bindLintFlags, bindInstallFlags)
 	if err != nil {
-		fmt.Println(err)
+		fmt.Printf("Error loading configuration: %s\n", err)
 		os.Exit(1)
 	}
 
 	testing := chart.NewTesting(*configuration)
 	results, err := testing.LintAndInstallCharts()
 	if err != nil {
-		fmt.Println("Error linting and installing charts")
+		fmt.Printf("Error linting and installing charts: %s\n", err)
 	} else {
 		fmt.Println("All charts linted and installed successfully")
 	}

pkg/chart/chart.go

@@ -419,11 +419,11 @@ func (t *Testing) ComputeChangedChartDirectories() ([]string, error) {
 
 	mergeBase, err := t.git.MergeBase(fmt.Sprintf("%s/%s", cfg.Remote, cfg.TargetBranch), "HEAD")
 	if err != nil {
-		return nil, errors.Wrap(err, "Could not determine changed charts: Error identifying merge base.")
+		return nil, errors.Wrap(err, "Error identifying merge base")
 	}
 	allChangedChartFiles, err := t.git.ListChangedFilesInDirs(mergeBase, cfg.ChartDirs...)
 	if err != nil {
-		return nil, errors.Wrap(err, "Could not determine changed charts: Error creating diff.")
+		return nil, errors.Wrap(err, "Error creating diff")
 	}
 
 	var changedChartDirs []string

pkg/tool/git.go

@@ -51,7 +51,7 @@ func (g Git) ListChangedFilesInDirs(commit string, dirs ...string) ([]string, er
 	changedChartFilesString, err :=
 		g.exec.RunProcessAndCaptureOutput("git", "diff", "--find-renames", "--name-only", commit, "--", dirs)
 	if err != nil {
-		return nil, errors.Wrap(err, "Could not determined changed charts: Error creating diff.")
+		return nil, errors.Wrap(err, "Error creating diff")
 	}
 	if changedChartFilesString == "" {
 		return nil, nil