Fix readiness check (#57)

unguiculus · web-flow · commit 739aa607a826 · 2018-11-16T13:53:53.000+01:00
Readiness check should happen before tests are executed. Otherwise
the fails if there are tests and test pods match the label selectors
that identify pods. Since test pods have status Completed, they
cause the readiness check to fail.

Signed-off-by: Reinhard Nägele &lt;unguiculus@gmail.com&gt;
diff --git a/pkg/tool/helm.go b/pkg/tool/helm.go
@@ -68,11 +68,11 @@ func (h Helm) InstallWithValues(chart string, valuesFile string, namespace strin
 		return err
 	}
 
-	if err := h.exec.RunProcess("helm", "test", release, h.extraArgs); err != nil {
+	if err := h.kubectl.WaitForDeployments(namespace); err != nil {
 		return err
 	}
 
-	return h.kubectl.WaitForDeployments(namespace)
+	return h.exec.RunProcess("helm", "test", release, h.extraArgs)
 }
 
 func (h Helm) DeleteRelease(release string) {

Original file line number	Diff line number	Diff line change
`@@ -68,11 +68,11 @@ func (h Helm) InstallWithValues(chart string, valuesFile string, namespace strin`
`68`	`68`	`return err`
`69`	`69`	`}`
`70`	`70`
`71`		`- if err := h.exec.RunProcess("helm", "test", release, h.extraArgs); err != nil {`
	`71`	`+ if err := h.kubectl.WaitForDeployments(namespace); err != nil {`
`72`	`72`	`return err`
`73`	`73`	`}`
`74`	`74`
`75`		`- return h.kubectl.WaitForDeployments(namespace)`
	`75`	`+ return h.exec.RunProcess("helm", "test", release, h.extraArgs)`
`76`	`76`	`}`
`77`	`77`
`78`	`78`	`func (h Helm) DeleteRelease(release string) {`