Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dev-deps): update to rollup 3 #456

Merged
merged 2 commits into from
Feb 16, 2023
Merged

chore(dev-deps): update to rollup 3 #456

merged 2 commits into from
Feb 16, 2023

Conversation

Xhale1
Copy link
Collaborator

@Xhale1 Xhale1 commented Feb 16, 2023

  • Update from rollup 2 to 3
  • Update other rollup packages to support v3
  • Replace deprecated rollup-plugin-terser with the official @rollup/plugin-terser
  • Remove rollup-plugin-size-snapshot
    • Hasn't been updated in three years
    • Causes builds to fail when using nodejs 18
    • Alternatives don't have much buy-in

Losing size snapshots is sad but it seems our peers don't have similar functionality. Unless one of us wants to maintain that lib, I'm happy reducing our dependency footprint and removing it.

@vercel
Copy link

vercel bot commented Feb 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
dnd ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 16, 2023 at 7:53AM (UTC)

Copy link
Collaborator

@100terres 100terres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👌

@Xhale1 Xhale1 changed the title chore: rollup 3 chore(dev-deps): update to rollup 3 Feb 16, 2023
@Xhale1 Xhale1 merged commit a00d7af into main Feb 16, 2023
@Xhale1 Xhale1 deleted the chore/rollup-3 branch February 16, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants