adds: base16 default dark theme for Helix editor

[raygervais]

Theme sample:

Go

Rust

[kirawi]

You can have a [palette] section as well so you don't have to copy-paste the same hex values over and over again. e.g.

type = { fg = "base00" }

[palette]
base00 = "#181818"

[Omnikar]

closes #699

I think you mean to say "closes #791"

[raygervais]

Corrected, thanks @Omnikar.

Will update your tip @kirawi, thanks for suggestion.

Any suggestions about determine the env and switching to this theme if appropriate?

[archseer]

A Base16 "true color" theme isn't quite the same as a 16 color theme that uses the terminal's default color scheme. So this won't close #791, but it's still appreciated :)

[archseer]

Which of the base16 themes is this by the way?

[archseer]

To use the terminal palette you specifically need to use black, red, light-red, etc. "#181818" is a hex color and requires true color support from the terminal.

[raygervais]

Default dark @archseer, and thanks for the explanation, will add to this existing PR the same which leverages exactly as you described and do my own research too.

For reference relating to the theme, http://chriskempson.com/projects/base16/

[archseer]

Looks like base16 actually won't be a good default unless the user is using a base16 theme: base16 sets the dark colors (0-7) to shades of grey instead, then the light colors (8-15) as actual colors.

A conventional palette uses 0-7 as dark/normal versions of the colors, then the rest as light colors: https://jeffkreeftmeijer.com/vim-16-color/

[archseer]

We might want a 256 color theme to be the fallback, the colors there are more standardized and most terminals support 256 colors.

[Omnikar]

We might want a 256 color theme to be the fallback, the colors there are more standardized and most terminals support 256 colors.

Ah, right.

[raygervais]

Update, going to look more into this and produce a proper theme which closes #791. Updating the Base 16 default dark theme here based on recommendations in case you want another color theme :D

[raygervais]

Just rebased from master, somehow it included other commits that shouldn't be there, so I can clean that up.

[raygervais]

And resolved, ready for review / advice @kirawi @archseer

[archseer]

Thanks! 🎉

[archseer]

Is this label enough or do you need it marked as hacktoberfest-accepted?

[raygervais]

I believe the latter, Hacktoberfest-accepted. Much appreciated

[pickfire]

I think it is a bit misleading to call this base16 as one will expect that it uses default terminal colors but it uses hex colors instead, most of the terminal have different color, some even light terminal so calling it this way will be confusing at first.

[archseer]

base16 is the name of the theme and it's quite widely known. It's different from a 16 color palette.