chore: add additional ignore file highlights #8220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you can add CODEOWNERS here aswell to also resolve #8091 |
languages.toml
Outdated
| @@ -1380,7 +1380,7 @@ source = { git = "https://github.com/mtoohey31/tree-sitter-gitattributes", rev = | |||
| name = "git-ignore" | |||
| scope = "source.gitignore" | |||
| roots = [] | |||
| file-types = [".gitignore", ".gitignore_global"] | |||
| file-types = [".gitignore", ".gitignore_global", ".ignore", "prettierignore", ".eslintignore", ".npmignore"] | |||
There was a problem hiding this comment.
Suggested change
| file-types = [".gitignore", ".gitignore_global", ".ignore", "prettierignore", ".eslintignore", ".npmignore"] | |
| file-types = [".gitignore", ".gitignore_global", ".ignore", ".prettierignore", ".eslintignore", ".npmignore"] |
|
Thanks for the suggestions - both addressed in new commit. |
pascalkuthe
previously approved these changes
Sep 9, 2023
rossmanch
force-pushed
the
add-more-ignore-highlights
branch
from
e43dfda
to
bc0bc79
Compare
|
Looks like I need to go back and learn how to read diffs as you didn't wrap it all. Hopefully now it's ok.... |
pascalkuthe
approved these changes
Sep 10, 2023
Various files use the same syntax highlighting as `.gitignore` and similarly tell different tools what files/folders to ignore. Update the languages file so that other ignore type files use the same highlighting as gitignore. The files added are: - `.ignore` - `.prettierignore` - `.eslintignore` - `.npmignore` Resolves: helix-editor#8089
Add `CODEOWNERS` as an additional file type for `git-ignore` in the language file. `CODEOWNERS`'s grammar is close enough to that of `.gitignore`, this can be used to avoid making a new grammar specifically for `CODEOWNERS` files. Resolves: helix-editor#8091
the-mikedavis
approved these changes
Sep 10, 2023
dgkf
pushed a commit
to dgkf/helix
that referenced
this pull request
Jan 30, 2024
* chore: add additional ignore file highlights Various files use the same syntax highlighting as `.gitignore` and similarly tell different tools what files/folders to ignore. Update the languages file so that other ignore type files use the same highlighting as gitignore. The files added are: - `.ignore` - `.prettierignore` - `.eslintignore` - `.npmignore` * chore: add highlighting for codeowners files Add `CODEOWNERS` as an additional file type for `git-ignore` in the language file. `CODEOWNERS`'s grammar is close enough to that of `.gitignore`, this can be used to avoid making a new grammar specifically for `CODEOWNERS` files.
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
* chore: add additional ignore file highlights Various files use the same syntax highlighting as `.gitignore` and similarly tell different tools what files/folders to ignore. Update the languages file so that other ignore type files use the same highlighting as gitignore. The files added are: - `.ignore` - `.prettierignore` - `.eslintignore` - `.npmignore` * chore: add highlighting for codeowners files Add `CODEOWNERS` as an additional file type for `git-ignore` in the language file. `CODEOWNERS`'s grammar is close enough to that of `.gitignore`, this can be used to avoid making a new grammar specifically for `CODEOWNERS` files.
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
* chore: add additional ignore file highlights Various files use the same syntax highlighting as `.gitignore` and similarly tell different tools what files/folders to ignore. Update the languages file so that other ignore type files use the same highlighting as gitignore. The files added are: - `.ignore` - `.prettierignore` - `.eslintignore` - `.npmignore` * chore: add highlighting for codeowners files Add `CODEOWNERS` as an additional file type for `git-ignore` in the language file. `CODEOWNERS`'s grammar is close enough to that of `.gitignore`, this can be used to avoid making a new grammar specifically for `CODEOWNERS` files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various files use the same syntax highlighting as
.gitignoreand similarly tell different tools what files/folders to ignore. Update the languages files so that other ignore type files use the same highlighting gitignore. The files added are:Resolves: #8089