Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smartcase regex search #761

Merged
merged 1 commit into from
Sep 20, 2021
Merged

Conversation

kraem
Copy link
Contributor

@kraem kraem commented Sep 15, 2021

First stab at smartcase search.

Some thoughts:

  • What's the desired behaviour for select_regex? Never enabled? Configured with a separate option?
  • Where would the regex builder live in helix-core? (so it can be used for other ui:s than term and Initial implementation of global search #651)

(edit: i didn't look at 651:s implementation before. guess the pr's not a reason for moving it to helix-core..)

Copy link
Member

@archseer archseer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the desired behaviour for select_regex? Never enabled? Configured with a separate option?

Default it to true.

Where would the regex builder live in helix-core?

Let's skip this for now, this PR is just a temporary workaround until we switch over to regex-automata in #211

helix-term/src/ui/mod.rs Outdated Show resolved Hide resolved
helix-view/src/editor.rs Outdated Show resolved Hide resolved
helix-view/src/editor.rs Outdated Show resolved Hide resolved
@kraem
Copy link
Contributor Author

kraem commented Sep 16, 2021

Thanks :) Fixed your comments. Also took the liberty of removing the todo and a comment.

@archseer
Copy link
Member

Thanks! Looks like there's a conflict, and I'd also mention the new option in the configuration section of the book. Other than that it looks good for merge.

@kraem kraem changed the title WIP: smartcase search smartcase regex search Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants