Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dart commit in languages.toml #7576

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

Queyrouzec
Copy link
Contributor

This fixes syntax highlighting problems with major Dart 3 update on classes, enums, and switch statements

This fixes syntax highlighting problems with major Dart 3 update on classes, enums, and switch statements
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like dispite the big changes to the grammar, the old queries are still compatible UserNobody14/tree-sitter-dart@2d7f666...e398400#diff-919ac210accac9ecc55a76d10a7590e3d85ca3f0e165b52d30f08faee486d0cb

It looks to me like mostly like refactoring and bugfixes but if we see some highlights change we can address those in follow-ups 👍

@the-mikedavis the-mikedavis added S-waiting-on-review Status: Awaiting review from a maintainer. A-language-support Area: Support for programming/text languages labels Jul 8, 2023
@Queyrouzec
Copy link
Contributor Author

Most of the commits are bug fixes but the addition of the new syntax was added under the commits for May 3rd, 2023 and the current commit is Aug 11, 2022.

@archseer archseer merged commit f68956a into helix-editor:master Jul 10, 2023
6 checks passed
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-language-support Area: Support for programming/text languages S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants