fix off-by-one git-commit rulers #7072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Characters should maximally reside *inside* the ruler, not on top of it.
the-mikedavis
approved these changes
May 19, 2023
pascalkuthe
approved these changes
May 19, 2023
aotarola
pushed a commit
to aotarola/helix
that referenced
this pull request
May 28, 2023
Characters should maximally reside *inside* the ruler, not on top of it.
aotarola
pushed a commit
to aotarola/helix
that referenced
this pull request
May 28, 2023
Characters should maximally reside *inside* the ruler, not on top of it.
Triton171
pushed a commit
to Triton171/helix
that referenced
this pull request
Jun 18, 2023
Characters should maximally reside *inside* the ruler, not on top of it.
wes-adams
pushed a commit
to wes-adams/helix
that referenced
this pull request
Jul 4, 2023
Characters should maximally reside *inside* the ruler, not on top of it.
elasticdog
added a commit
to elasticdog/dotfiles
that referenced
this pull request
Oct 31, 2023
This matches what is done by Helix for git-commit rulers so characters reside inside rather than on top of the ruler. See: - helix-editor/helix#7072
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
Characters should maximally reside *inside* the ruler, not on top of it.
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
Characters should maximally reside *inside* the ruler, not on top of it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Characters should maximally reside inside the ruler, not on top of it.
At least, that's my personal taste. Maybe the existing behavior is intentional?