Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hurl Support #6450

Merged
merged 2 commits into from
Apr 6, 2023
Merged

Add Hurl Support #6450

merged 2 commits into from
Apr 6, 2023

Conversation

erasin
Copy link
Contributor

@erasin erasin commented Mar 27, 2023

@erasin erasin marked this pull request as draft March 27, 2023 16:36
@the-mikedavis
Copy link
Member

This seems very niche to me. Functionality like vscode-restclient would certainly live in a plugin IMO and other than that, I can't think of a good use-case for HTTP highlighting in an editor

@erasin
Copy link
Contributor Author

erasin commented Mar 28, 2023

I use restclient to test WEB API, so I don't have to switch editor to postman, this is more than enough for my use.

@erasin erasin marked this pull request as ready for review March 28, 2023 16:21
@pickfire
Copy link
Contributor

pickfire commented Apr 4, 2023

I am not sure if I found what do you refer to as restclient, but is there a reason why hurl (which I supposed is more popular since I can google it) isn't used instead? https://hurl.dev/

There is tree sitter support for it https://github.com/pfeiferj/tree-sitter-hurl. Or is the .http thing something custom? Or like @the-mikedavis mentioned, it is really niche since I can't find it online.

@erasin erasin changed the title Add http Support Add Hurl Support Apr 5, 2023
@erasin
Copy link
Contributor Author

erasin commented Apr 5, 2023

@pickfire thanks!!! The hurl is awesome. I am a web developer, test api with restclient in vscode, and I has use helix a year time, some times must to switch vscode or postman API for test.

The hurl has support cli and chaining requests. It is can replace postman for simple test api, is very good to me.

I will change this pr with hurl.

@zetashift
Copy link
Contributor

I am not sure if I found what do you refer to as restclient, but is there a reason why hurl (which I supposed is more popular since I can google it) isn't used instead? https://hurl.dev/

There is tree sitter support for it https://github.com/pfeiferj/tree-sitter-hurl.

Ohh fan of Hurl here, I didn't know they had a tree-sitter grammar, hope to see this merged in!

@pickfire
Copy link
Contributor

pickfire commented Apr 6, 2023

cc @pfeiferj author to let them know we are using it

Comment on lines +7 to +8
((xml) @injection.content
(#set! injection.language "xml"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be html too?

Copy link
Contributor

@pickfire pickfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for sending this and hope hurl helps you.

@@ -2421,3 +2421,17 @@ language-server = { command = "nimlangserver" }
[[grammar]]
name = "nim"
source = { git = "https://github.com/aMOPel/tree-sitter-nim", rev = "240239b232550e431d67de250d1b5856209e7f06" }

[[language]]
name = "hurl"
Copy link
Contributor

@pickfire pickfire Apr 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add # http so people can search for it? I wonder.

Since the name hurl is not really useful.

Screenshot_20230407_002528

I like how doom emacs did it, they put some more description (and funny) description beside the original plugin so people know what is it for.

@the-mikedavis what do you think?

@pickfire pickfire merged commit c22ebfe into helix-editor:master Apr 6, 2023
@erasin
Copy link
Contributor Author

erasin commented Apr 7, 2023

@pickfire thanks for merged.

I have been using hurl test api for a few days now, and chaining api better than restclient.

Triton171 pushed a commit to Triton171/helix that referenced this pull request Jun 18, 2023
wes-adams pushed a commit to wes-adams/helix that referenced this pull request Jul 4, 2023
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants