Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fleet-dark improvements #6375

Merged
merged 1 commit into from
Mar 21, 2023
Merged

fleet-dark improvements #6375

merged 1 commit into from
Mar 21, 2023

Conversation

krfl
Copy link
Contributor

@krfl krfl commented Mar 20, 2023

A few changes that does not comply with the original theme, but adjusts the theme to better fit the editor of choice.

  • Statusline is now visible. This was an issue when using horizontal splits
  • ui.virtual was adjusted to a much lighter color. This is an issue only because we are using the "reversed" modifier for the cursor, and thus this change is required to make the cursor visible again when moving through whitespace. As a result, whitespace is now much more "in your face" when enabled. I consider this an okay price to pay. Feel free to disagree

Screenshot 2023-03-20 at 10 01 25
Screenshot 2023-03-20 at 10 02 21

@krfl
Copy link
Contributor Author

krfl commented Mar 20, 2023

@matoous @kirawi any thoughts?

@pickfire
Copy link
Contributor

Since you already wrote the reason in the pull request, why not just put it directly as comments in the original theme?

@matoous
Copy link
Contributor

matoous commented Mar 20, 2023

@krfl looks good to me 👍

kirawi
kirawi approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member

@kirawi kirawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@the-mikedavis the-mikedavis merged commit b0ceac6 into helix-editor:master Mar 21, 2023
@kirawi kirawi mentioned this pull request Mar 22, 2023
Closed
icecreammatt pushed a commit to icecreammatt/helix that referenced this pull request Apr 19, 2023
@krfl @icecreammatt
fleet-dark improvements (helix-editor#6375)
da2b60a 
Co-authored-by: krfl <[email protected]>
wes-adams pushed a commit to wes-adams/helix that referenced this pull request Jul 4, 2023
@krfl @wes-adams
fleet-dark improvements (helix-editor#6375)
86d4886 
Co-authored-by: krfl <[email protected]>
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
@krfl
fleet-dark improvements (helix-editor#6375)
2b3be09 
Co-authored-by: krfl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-mikedavis the-mikedavis the-mikedavis approved these changes

@kirawi kirawi kirawi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@krfl @pickfire @matoous @the-mikedavis @kirawi