Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Monokai Theme #628

Merged
merged 3 commits into from
Aug 25, 2021
Merged

Add Monokai Theme #628

merged 3 commits into from
Aug 25, 2021

Conversation

kirawi
Copy link
Member

@kirawi kirawi commented Aug 20, 2021

I don't intend to use this, but I thought it was cool enough that maybe others might like it.
Capture

@pickfire
Copy link
Contributor

I think if you don't use it, then it will be unmaintained later on. Is it a good idea to pull it in, maybe you can just keep this pull request until someone needs it?

@Surendrajat
Copy link
Contributor

I'm a huge fan of Monokai theme and will appreciate if it's included with package.

@kirawi
Copy link
Member Author

kirawi commented Aug 21, 2021

I'm a huge fan of Monokai theme and will appreciate if it's included with package.

I'll try to finish it up today :)

@kirawi
Copy link
Member Author

kirawi commented Aug 24, 2021

Found some places where we could improve upon the Rust highlighting, might have to do that eventually. I just need to clean it up a bit and then it'll be ready for review. The theme itself is otherwise done.

@kirawi kirawi marked this pull request as ready for review August 24, 2021 23:54
@archseer archseer merged commit 44a0512 into helix-editor:master Aug 25, 2021
@kirawi kirawi deleted the monokai branch August 25, 2021 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants