Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(commands): add clear_registers command #5695

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

chorcheus
Copy link
Contributor

@chorcheus chorcheus commented Jan 26, 2023

Closes #4256. This is a rework of closed #4408. Summary of discussion from there:

  • clear registers by pressing " and then the key to clear the registers
  • the key to clear the registers is suggested to be |

@the-mikedavis
Copy link
Member

We could also consider not adding a keybinding for this. You would need to execute it through the command palette <space>? but I don't think that's a problem since this isn't something you need to do very often (if at all)

@the-mikedavis the-mikedavis added A-helix-term Area: Helix term improvements S-waiting-on-review Status: Awaiting review from a maintainer. labels Jan 26, 2023
@chorcheus chorcheus force-pushed the jrg-delete-registers branch 2 times, most recently from 76277a4 to 910de8f Compare January 30, 2023 19:18
@chorcheus
Copy link
Contributor Author

chorcheus commented Jan 30, 2023

@the-mikedavis Thanks, I added the changes.

@archseer
Copy link
Member

archseer commented Feb 1, 2023

This could be a typable command? :clear-register @

helix-term/src/commands.rs Outdated Show resolved Hide resolved
helix-term/src/commands/typed.rs Outdated Show resolved Hide resolved
@chorcheus chorcheus force-pushed the jrg-delete-registers branch 2 times, most recently from 799aebb to 1ff30f8 Compare February 4, 2023 22:16
@chorcheus chorcheus force-pushed the jrg-delete-registers branch 2 times, most recently from b5adc21 to 6d8d83b Compare February 12, 2023 19:55
dead10ck
dead10ck previously approved these changes Feb 28, 2023
Copy link
Member

@dead10ck dead10ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to me 👍

@chorcheus
Copy link
Contributor Author

@the-mikedavis could you please look at this? Are you OK with the current implementation?

@pascalkuthe pascalkuthe merged commit 204d1eb into helix-editor:master Apr 27, 2023
Triton171 pushed a commit to Triton171/helix that referenced this pull request Jun 18, 2023
wes-adams pushed a commit to wes-adams/helix that referenced this pull request Jul 4, 2023
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete registers
6 participants