Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable http server by default in Metals config #5551

Merged
merged 1 commit into from
Jan 16, 2023

Conversation

ayoub-benali
Copy link
Contributor

@ayoub-benali ayoub-benali commented Jan 16, 2023

This is required to make commands like doctor-run work. It simply opens a browser to get general information about the build.

isHttpEnabled

This is required to make commands like [doctor-run](https://scalameta.org/metals/docs/integrations/new-editor#run-doctor) work.
It simply opens a browser to get general information about the build.
@ayoub-benali
Copy link
Contributor Author

cc @tgodzik @ckipp01

@pascalkuthe
Copy link
Member

Is this still needed once #5492 is merged?

@ayoub-benali
Copy link
Contributor Author

Yes, it is still needed

@the-mikedavis the-mikedavis merged commit 97083f8 into helix-editor:master Jan 16, 2023
gibbz00 pushed a commit to gibbz00/helix that referenced this pull request Jan 17, 2023
This is required to make commands like [doctor-run](https://scalameta.org/metals/docs/integrations/new-editor#run-doctor) work.
It simply opens a browser to get general information about the build.

Co-authored-by: Ayoub Benali <[email protected]>
kirawi pushed a commit to kirawi/helix that referenced this pull request Jan 25, 2023
This is required to make commands like [doctor-run](https://scalameta.org/metals/docs/integrations/new-editor#run-doctor) work.
It simply opens a browser to get general information about the build.

Co-authored-by: Ayoub Benali <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants