-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(commands): extend_line to proper line when count and current line selected #5288
Conversation
for both extend_line_(above/below) the check for if current line is selected now works if there is a count
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be nice to add an integration test for in helix-term/tests/test/commands.rs
Sorry about that, I was thinking about doing that but totally forgot. Integration tests have been added now, it needed a trailing newline to work cause the test would add an extra newline after end if it didn't exist. |
for both extend_line_(above/below) the check for if current line is selected now works if there is a count:
this now means if you select a line with
x
and then do2x
3 lines will be selected whereas before only 2 lines would be, this keeps2x
on a not fully selected line only selecting 2 lines which is the desired functionality ofextend_line
fixes #5270