Fix kanagawa theme lint and added git gutter colors #5273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comprises 4 changes: 1. added "sumiInk3" as ui.cursorline.primary bg color 2. switched the cursor bg and fg colors (now in line with original theme) 3. added ui.menu and ui.selected colors 4. separated ui.selection and ui.selection.primary
In line with original: autumnGreen for adds autumnRed for deletes autumnYellow for changes
leonqadirie
changed the title
the-mikedavis
added
A-theme
* indent-guides are sumiInk4 * Add ui.linenr.selected is roninYellow
zetashift
approved these changes
Dec 27, 2022
There was a problem hiding this comment.
Sorry for the late review, I was sick for a bit.
Just for some more context, when I made the initial version, it was a crude attempt, because I don't know all that much about the Helix options.
These changes look good to me however, I like the Git additions.
EDIT: I am no official reviewer tho, so I'll wait till somebody with rights can look at this
the-mikedavis
approved these changes
Dec 28, 2022
semin-park
pushed a commit
to semin-park/helix
that referenced
this pull request
Jan 4, 2023
* Fix kanagawa theme lint Comprises 4 changes: 1. added "sumiInk3" as ui.cursorline.primary bg color 2. switched the cursor bg and fg colors (now in line with original theme) 3. added ui.menu and ui.selected colors 4. separated ui.selection and ui.selection.primary * Add git gutter colors to kanagawa theme In line with original: autumnGreen for adds autumnRed for deletes autumnYellow for changes * Add indent-guides and linenr.selected to kanagawa * indent-guides are sumiInk4 * Add ui.linenr.selected is roninYellow * Set ui.help bg to sumiInk1
hadronized
pushed a commit
to hadronized/helix
that referenced
this pull request
Jan 4, 2023
* Fix kanagawa theme lint Comprises 4 changes: 1. added "sumiInk3" as ui.cursorline.primary bg color 2. switched the cursor bg and fg colors (now in line with original theme) 3. added ui.menu and ui.selected colors 4. separated ui.selection and ui.selection.primary * Add git gutter colors to kanagawa theme In line with original: autumnGreen for adds autumnRed for deletes autumnYellow for changes * Add indent-guides and linenr.selected to kanagawa * indent-guides are sumiInk4 * Add ui.linenr.selected is roninYellow * Set ui.help bg to sumiInk1
freqmod
pushed a commit
to freqmod/helix
that referenced
this pull request
Feb 8, 2023
* Fix kanagawa theme lint Comprises 4 changes: 1. added "sumiInk3" as ui.cursorline.primary bg color 2. switched the cursor bg and fg colors (now in line with original theme) 3. added ui.menu and ui.selected colors 4. separated ui.selection and ui.selection.primary * Add git gutter colors to kanagawa theme In line with original: autumnGreen for adds autumnRed for deletes autumnYellow for changes * Add indent-guides and linenr.selected to kanagawa * indent-guides are sumiInk4 * Add ui.linenr.selected is roninYellow * Set ui.help bg to sumiInk1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comprises 4 changes:
@zetashift please take a look; especially regarding my choice of color for change 4.
--
Edit: now 8 changes:
5. added the theme's official git gutter colors to address kanagawa's share of #4972
6. added "sumiInk4" as ui.virtual.indent-guide
7. added "roninYellow" as ui.linenr.selected
8. set ui.help bg to "sumiInk1"