fix(themelint): add diff for git gutter #5037
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 7, 2022
Closed
pascalkuthe
added
A-theme
|
this pr has been stale for over a year and I don't see us moving forward with this. We have pretty good diff gutter symbols these days. We don't really want to focus on the themelint (and may remove it entirely in the future). Thanks for contributing |
|
FWIW; I'm totally fine with removing the themelint. It did not pan out as I hoped since it never got to be part of CI. I do think it's a shame that some features feel buggy on some/most themes (the recent jump labels f.ex) but as it takes 5 minutes to find out how to fix it locally I guess it's just one of those things... :) Down the line I guess themes will be plugin, which places the blame more clearly on the theme and not on Helix 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #4972 this adds a check for
diff.[plus|minus|delta]and for them to be different.