Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): broken LSPs on monorepos #4439

Closed
wants to merge 8 commits into from

Commits on Nov 14, 2022

  1. fix: find_root always matching same root

    the find_root function should match the top most root directory for a given file. However, due to not checking if the root was already present, it was overwriting the response so it always matched the bottom most root directory (most commonly the git directory). This broke the expected behavior for projects like monorepos with multiple root directories.
    georgesboris committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    a914acc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c3b7a60 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f6d39d5 View commit details
    Browse the repository at this point in the history
  4. fix: clippy warnings

    georgesboris committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    2574dfd View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    60da13c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a73571b View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    3a34d0b View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2022

  1. Configuration menu
    Copy the full SHA
    3a3edad View commit details
    Browse the repository at this point in the history