Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to load files in the background without closing the picker #4435

Merged
merged 1 commit into from
Jan 16, 2023
Merged

Add ability to load files in the background without closing the picker #4435

merged 1 commit into from
Jan 16, 2023

Conversation

emilyyyylime
Copy link
Contributor

@emilyyyylime emilyyyylime commented Oct 23, 2022 •
edited
Loading

Closes #3924. This is a pretty small change but everyone has to start somewhere :P

@the-mikedavis the-mikedavis added A-keymap Area: Keymap and keybindings S-waiting-on-review Status: Awaiting review from a maintainer. labels Oct 23, 2022
the-mikedavis
the-mikedavis approved these changes Oct 23, 2022
View reviewed changes
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a fan of this - I run into this situation a lot too where you want to open a file and keep the picker open (usually to change query) but want to open the file, as a more convenient way than <space>'

dead10ck
dead10ck approved these changes Oct 24, 2022
View reviewed changes
Copy link
Member

@dead10ck dead10ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lukepighetti
Copy link

What's stopping this from merging?

@dead10ck
Copy link
Member

dead10ck commented Dec 10, 2022 •
edited
Loading

A review from @archseer. There's quite a big backlog, so it takes time to get to everyone.

@archseer archseer merged commit d3e0f18 into helix-editor:master Jan 16, 2023
gibbz00 pushed a commit to gibbz00/helix that referenced this pull request Jan 17, 2023
@emilyyyylime @gibbz00
Added opening files in the background with A-ret shortcut (helix-edit…
6cfc82c 
…or#4435)
kirawi pushed a commit to kirawi/helix that referenced this pull request Jan 25, 2023
@emilyyyylime
Added opening files in the background with A-ret shortcut (helix-edit…
7b58233 
…or#4435)
@woojiq woojiq mentioned this pull request Jul 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dead10ck dead10ck dead10ck approved these changes

@the-mikedavis the-mikedavis the-mikedavis approved these changes

Assignees
No one assigned
Labels
A-keymap Area: Keymap and keybindings S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

S-return in file picker should open file in the background and keep the picker open with the same search query
5 participants
@emilyyyylime @lukepighetti @dead10ck @the-mikedavis @archseer