Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helix-term: send the STOP signal to all processes in the process group #3546

Merged
merged 5 commits into from
Mar 13, 2023
Merged

helix-term: send the STOP signal to all processes in the process group #3546

merged 5 commits into from
Mar 13, 2023

Commits on Mar 9, 2023

  1. helix-term: send the STOP signal to all processes in the process group 

    From kill(3p):

    If pid is 0, sig shall be sent to all processes (excluding an unspecified set
    of  system processes) whose process group ID is equal to the process group ID
    of the sender, and for which the process has permission to send a signal.

This fixes the issue of running `git commit`, attempting to suspend
helix with ^Z, and then not regaining control over the terminal and
having to press ^Z again.
    @cole-h
    cole-h committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    f2769cb View commit details
    Browse the repository at this point in the history

  2. helix-term: use libc directly to send STOP signal

    @cole-h
    cole-h committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    553e0ea View commit details
    Browse the repository at this point in the history

  3. helix-term: document safety of libc::kill

    @cole-h
    cole-h committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    4a68f1f View commit details
    Browse the repository at this point in the history

  4. helix-term: properly handle libc::kill's failure 

    I misread the manpage for POSIX `kill` -- it returns `-1` in
the failure case, and sets `errno`, which is retrieved via
`std::io::Error::last_os_error()`, has its string representation printed
out, and then exits with the matching status code (or 1 if, for whatever
reason, there is no matching status code).
    @cole-h
    cole-h committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    0e3b9f2 View commit details
    Browse the repository at this point in the history

  5. helix-term: expand upon why we need to SIGSTOP the entire process group 

    Also add a link back to one of the upstream issues.
    @cole-h
    cole-h committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    6d7b713 View commit details
    Browse the repository at this point in the history