Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect indent-style in :set-language #3330

Merged

Conversation

the-mikedavis
Copy link
Member

Indent style may change when choosing a language with :set-language.
Line-endings most likely will not change, but :set-language should
have a similar effect as reloading a file (:reload), plus the two
are currently grouped in the implementation and line-ending detection
is not particularly expensive.

That this didn't happen (prior to this change) is more noticeable because of #3095

@the-mikedavis the-mikedavis changed the title Refresh indent-style in :set-language Detect indent-style in :set-language Aug 4, 2022
Indent style may change when choosing a language with `:set-language`.
Line-endings most likely will not change, but `:set-language` should
have a similar effect as reloading a file (`:reload`), plus the two
are currently grouped in the implementation and line-ending detection
is not particularly expensive.
@AceofSpades5757
Copy link
Contributor

I'm actually surprised that this doesn't update the settings, like a :config-reload or something to that effect.

Copy link
Contributor

@AceofSpades5757 AceofSpades5757 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested indentation level using text to html. Looks good!

@archseer archseer merged commit f32c05d into helix-editor:master Aug 5, 2022
@the-mikedavis the-mikedavis deleted the md-set_language-detect-indent branch August 5, 2022 00:13
thomasskk pushed a commit to thomasskk/helix that referenced this pull request Sep 9, 2022
Indent style may change when choosing a language with `:set-language`.
Line-endings most likely will not change, but `:set-language` should
have a similar effect as reloading a file (`:reload`), plus the two
are currently grouped in the implementation and line-ending detection
is not particularly expensive.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants