Fix terminal cursor shape reset #3289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1B[0 q' to restore cursor to user default after exiting helix
the-mikedavis
changed the title
|
This is probably a better default to reset back to, but we do want a better solution in the future that reads |
GreasySlug
pushed a commit
to GreasySlug/helix
that referenced
this pull request
Aug 2, 2022
…1B[0 q' to restore cursor to user default after exiting helix (helix-editor#3289)
|
Just want to give you a heads up that I use they/them and not he/him, it'd mean a lot if you edited your message accordingly, thank you |
thomasskk
pushed a commit
to thomasskk/helix
that referenced
this pull request
Sep 9, 2022
…1B[0 q' to restore cursor to user default after exiting helix (helix-editor#3289)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed this line by changing the 2 to a 0.
The previous escape code
\x1B[2 qsets the cursor to be a static block according to this specification. The new escape code\x1B[0 qrestores the cursor to the user's default.To be honest, I'm not sure if this will fix the issue for everyone. It fixes it for me on arch linux using gnome and with the alacritty terminal. With this change, when I exit out of helix, my terminal cursor is restored to a blinking underscore.
@DivergentClouds found the solution, which they shared in issue #2684.
There are also several other terminal-based editors that have had this same issue of not restoring the user's terminal cursor style, such as here and here.