Shorten embedded command descriptions #3070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Compact descriptions in command palette and infobox
sudormrfbin
force-pushed
the
shorten-command-descriptions
branch
from
62fdcc8
to
76c8c97
Compare
| repeat_last_motion, "repeat last motion(extend_next_char, extend_till_char, find_next_char, find_till_char...)", | ||
| repeat_last_motion, "Repeat last motion", |
There was a problem hiding this comment.
Somewhat unrelated to the change here, this tends to be a source of confusion that A-. doesn't work on motions like w, just on these find-type motions (same behavior as Kakoune). Maybe we should have a different word for those kinds of motions?
There was a problem hiding this comment.
There seems to be some inconsistency in the implementation though, since it works with shrink/expand syntax node selection and all textobjects in addition to the find type motions. Shouldn't repeat_last_motion repeat any kind of motion, including w, b, etc? Is there any particular reason kakoune chose to go that way?
thomasskk
pushed a commit
to thomasskk/helix
that referenced
this pull request
Sep 9, 2022
* Shorten embedded command descriptions - Compact descriptions in command palette and infobox * Shorten typed command descriptions * Fix typo in decrement command description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mainly gives us more compact descriptions that will fit better with the command palette and the infobox.