Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix backwards selection duplication widening bug #2945

Merged
merged 3 commits into from
Jul 4, 2022
Merged

Fix backwards selection duplication widening bug #2945

merged 3 commits into from
Jul 4, 2022

Conversation

A-Walrus
Copy link
Contributor

@A-Walrus A-Walrus commented Jul 2, 2022

Fixes #2854

@sudormrfbin
Copy link
Member

This would benefit from integration tests, see https://github.com/helix-editor/helix/tree/master/helix-term/tests/test for examples of testing indent, auto pairs, etc.

@A-Walrus

This comment was marked as resolved.

Sign in to view
@A-Walrus
Make tests line-ending agnostic
07db29a 
Make tests line-ending agnostic

Use indoc to fix tests

Fix line-ending on test input
the-mikedavis
the-mikedavis approved these changes Jul 4, 2022
View reviewed changes
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

The tests look great! Thanks for the fix

@archseer archseer merged commit 2ac1de3 into helix-editor:master Jul 4, 2022
@the-mikedavis the-mikedavis mentioned this pull request Jul 6, 2022
Closed
@A-Walrus A-Walrus deleted the backwards_selection branch August 1, 2022 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-mikedavis the-mikedavis the-mikedavis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Backward Selection Duplication Widening Selection.
4 participants
@A-Walrus @sudormrfbin @the-mikedavis @archseer