Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(commands): add log-open command #2422

Merged
merged 1 commit into from
May 11, 2022

Conversation

amaihoefner
Copy link
Contributor

@amaihoefner amaihoefner commented May 6, 2022

My first small contribution to an open source project.
I hope that all is in order.
Implements #2418

@the-mikedavis
Copy link
Member

the-mikedavis commented May 6, 2022

To clear up that ❌ from the Docs CI, you can run cargo xtask docgen and commit the changes

Copy link
Member

@dead10ck dead10ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@@ -63,5 +63,6 @@
| `:tree-sitter-subtree`, `:ts-subtree` | Display tree sitter subtree under cursor, primarily for debugging queries. |
| `:config-reload` | Refreshes helix's config. |
| `:config-open` | Open the helix config.toml file. |
| `:log-open` | Open the helix log file. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not aware if this is from other editors? Why do we want to do this rather something like variable $VIMRUNTIME?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer this too, but we'd need to add support for variables. Once we do we'll remove these commands

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not aware if this is from other editors? Why do we want to do this rather something like variable $VIMRUNTIME?

IMO, as the "post-modern" editor, I think Helix's point is exactly to have some features that other editors doesn't have.
Although read it from a variable is pretty handy too!

@archseer archseer merged commit a5bc69c into helix-editor:master May 11, 2022
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 15, 2022
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants