grammars.nix: use github type for fetchTree where possible #1872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-mikedavis
approved these changes
Mar 28, 2022
There was a problem hiding this comment.
I think I remember seeing a speed boost from switching to shallow. It was really horribly slow before shallow on really large repos like tree-sitter-c-sharp.
I thought we'd have to use fetchFromGitHub to get the fast tarball stuff, TIL about type = "github";! 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fetchTree with git is slow even with shallow cloning. It might also be that shallow cloning simply doesn't work. Either way, the github fetcher is much faster as it downloads a tarball using the GitHub API. All the current grammars are from GitHub so this should reduce fetch time a lot.