Fix suspend when running hx within git #1843
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When editing git commit message using helix, when ctrl-z is pressed the terminal will get stuck since helix does not suspend correctly, as helix is currently using tokio with multi-threads, with signal-hook default low_level::emulate_default_handler it only send the SIGSTOP to the current process but tokio uses multi-process so not everything gets suspended and the terminal also gets stuck. Now switched to use libc kill function and send it to pid 0 so that all processes gets suspended correctly.
pickfire
commented
Mar 19, 2022
| // git suspend will not work since only the current process | ||
| // is suspended, so we had to send SIGSTOP signal to the | ||
| // whole process to make sure it is suspended correctly. | ||
| signal::kill(Pid::from_raw(0), Signal::SIGSTOP).unwrap(); |
There was a problem hiding this comment.
@archseer I can change it to libc::kill if you want since nix is an extra new crate now (libc we already need it anyway) but we only use this one line, but using libc directly will need unsafe and might take up several lines.
archseer
reviewed
Mar 19, 2022
| use nix::{ | ||
| sys::signal::{self, Signal}, | ||
| unistd::Pid, | ||
| }; | ||
| self.compositor.save_cursor(); | ||
| self.restore_term().unwrap(); |
There was a problem hiding this comment.
It seems to me that you didn't follow the signal-hook docs: you're supposed to call low_level::raise(SIGSTOP)?;, not emulate_default_handler: https://docs.rs/signal-hook/latest/signal_hook/#a-complex-signal-handling-with-a-background-thread
There was a problem hiding this comment.
Hmm, seems to be the same underlying call though
There was a problem hiding this comment.
Yes, it's the same thing.
|
Should fix this within signal-hook |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When editing git commit message using helix, when ctrl-z is pressed
the terminal will get stuck since helix does not suspend correctly,
as helix is currently using tokio with multi-threads, with signal-hook
default low_level::emulate_default_handler it only send the SIGSTOP to
the current process but tokio uses multi-process so not everything gets
suspended and the terminal also gets stuck.
Now switched to use libc kill function and send it to pid 0 so that all
processes gets suspended correctly.
Maybe I need to create an issue in signal-hook for this to check why they didn't kill all processes.