Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jumplist support for the search (closes #1625) #1718

Merged
merged 1 commit into from
Mar 1, 2022

Conversation

Philipp-M
Copy link
Contributor

Should fix #1625

I'm not sure if this is everything that is required (i.e. if I missed some edge cases), I'm not yet deep into the codebase...
But so far everything seems to be working fine for me.

One thing I noticed with this change, is that if in selection mode and extending (extend_search_next, extend_search_previous), this is also added into the jumplist, I'm not sure if this good or bad (I like it for now, which is why I left it as is)

helix-term/src/ui/mod.rs Outdated Show resolved Hide resolved
helix-term/src/commands.rs Outdated Show resolved Hide resolved
@archseer archseer merged commit 49c5bc5 into helix-editor:master Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jumping via search doesn't add to the jumplist
3 participants