Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement bulk buffer closing commands #1677

Merged
merged 8 commits into from
Mar 1, 2022
Merged

Implement bulk buffer closing commands #1677

merged 8 commits into from
Mar 1, 2022

Commits on Feb 27, 2022

  1. Implement buffer-close-all

    @EpocSquadron
    EpocSquadron committed Feb 27, 2022
    Configuration menu
    Copy the full SHA
    83b94ac View commit details
    Browse the repository at this point in the history

  2. Implement buffer-close-others

    @EpocSquadron
    EpocSquadron committed Feb 27, 2022
    Configuration menu
    Copy the full SHA
    0855cd0 View commit details
    Browse the repository at this point in the history

  3. Refactor all buffer close variants to use shared logic

    @EpocSquadron
    EpocSquadron committed Feb 27, 2022
    Configuration menu
    Copy the full SHA
    b19b287 View commit details
    Browse the repository at this point in the history

  4. Fix clippy lint

    @EpocSquadron
    EpocSquadron committed Feb 27, 2022
    Configuration menu
    Copy the full SHA
    e32c714 View commit details
    Browse the repository at this point in the history

  5. Docgen for new commands

    @EpocSquadron
    EpocSquadron committed Feb 27, 2022
    Configuration menu
    Copy the full SHA
    4620e23 View commit details
    Browse the repository at this point in the history

  6. Shorten error message for attempting to close buffers that don't exist

    @EpocSquadron
    EpocSquadron committed Feb 27, 2022
    Configuration menu
    Copy the full SHA
    78ae600 View commit details
    Browse the repository at this point in the history

  7. Refactor shared buffer methods to pass only editor, not whole compositor

    @EpocSquadron
    EpocSquadron committed Feb 27, 2022
    Configuration menu
    Copy the full SHA
    d011456 View commit details
    Browse the repository at this point in the history

  8. Switch signature of bulk buffer closing to use slice of DocumentIds 

    Addresses feedback that accepting an IntoIterator implementor is too
much for an internal. Also possibly saves some moving?
    @EpocSquadron
    EpocSquadron committed Feb 27, 2022
    Configuration menu
    Copy the full SHA
    9a94e1d View commit details
    Browse the repository at this point in the history