Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement bulk buffer closing commands #1677

Merged

Conversation

EpocSquadron
Copy link
Contributor

These are convenience methods for cleaning up accumulated buffers as described in #1637.

This could probably be further cleaned up to unify the buffer_close_impl in a way that works for all of the various buffer closing commands, but for now this is effective in my testing. Also I ran out of time, and wanted to get something up. Feel free to rip apart and I'll address later.

@EpocSquadron EpocSquadron force-pushed the epocsquadron/add-buffer-close-all branch from 43e6c6f to b00c196 Compare February 19, 2022 04:54
@EpocSquadron
Copy link
Contributor Author

Refactored the buffer close commands to all use shared logic, and rebased.

@EpocSquadron EpocSquadron force-pushed the epocsquadron/add-buffer-close-all branch from facceba to 9a94e1d Compare February 27, 2022 12:57
@EpocSquadron
Copy link
Contributor Author

Clippy lint is unrelated to this pull request.

@archseer archseer merged commit 78d37fd into helix-editor:master Mar 1, 2022
@EpocSquadron EpocSquadron deleted the epocsquadron/add-buffer-close-all branch March 1, 2022 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants