feat(languages): rescript #1616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you proficient enough to add textobject queries? Should be a fairly easy add. You're also missing a line ending in the languages.toml. |
EpocSquadron
reviewed
Feb 4, 2022
|
You'll also need to rerun xtask to pick up the textobject support in the language support table. |
EpocSquadron
reviewed
Feb 4, 2022
|
Almost there! Sorry to be nagging, but it's "around" instead of "outside". I'm working on a screencast walkthrough of how these queries work, I regret that it wasn't ready to give to you up front and make this easier on you. |
|
No worries, I totally missed that it was supposed to be |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there,
This PR adds support for the rescript language!