Add command for picking files from CWD

[gavynriebau]

The file_picker_at_cwd command opens the file picker at the current
working directory (CWD). This can be useful when paired with the
built-in :cd command which changes the CWD.

[gavynriebau]

Demo

file_picker_at_cwd.mp4

In the above demo I remapped space f to a "Files" submenu which contains entries for both the original "Open file picker" and the new "Open file picker at current working directory" commands.

I haven't included that keymapping change in this PR due to ongoing discussion in #1352 about the best way to keymap new file picker type commands.

[EpocSquadron]

There is an interesting interaction here with some of the logic inside the file_picker method, where it decides whether to limit the number of items in the picker to 8196 if the root directory is not a directory containing a .git. This could theoretically impact the sorting in a subdirectory if the subdirectory is quite large, I think.

[sudormrfbin]

There's also #1066 that gives higher precedence to files in the CWD in the default file picker itself.

[gavynriebau]

There's also #1066 that gives higher precedence to files in the CWD in the default file picker itself.

Thanks, the issue is that if there are a large number of directories/files in the root of a project, they will clutter up the list of results.
Being able to cd to a subdirectory and the pop the file picker in a mode that only shows the files in the CWD would be really useful to me because provides a smaller and clearer list of results to pick from.

[archseer]

How about mapping this to space F by default? Would complement space f

[archseer]

Let's also rename it file_picker_in_current_directory

[gavynriebau]

Thanks, I've renamed the function, added a keymap bound to space F, rebased onto the latest master and pushed the updated changes into this PR

[slinlee]

Resolves #1860

[archseer]

Thanks!

[David-Else]

If I open Helix in a directory and pwd it says that is the current working directory. Is this not the main working directory as opposed to/as well as the current working directory? If we now have a file picker for the current working directory then there needs to be a new distinction between the two.

If I cd into a subdirectory x then it says current working directory is now x.

• space f opens the previous directory (main working directory?),
• space F opens x (current working directory).

The menu says "f Open file picker", but open it where? Is this known as the main working directory or some other name? If so, it should say in the menu as things are now confusing.

There is now two distinct types of directory for the file picker, and the main working directory needs to be referenced in the docs and other commands now.

PS I am not saying it needs to be called main working directory, but what should it be called? git root? Is it decided in a different way by each LSP server, or is it just the first directory you open?

[the-mikedavis]

I think "workspace directory" would be an improvement, but that might start to cross terminology with LSP.

[David-Else]

We need to clarify what is:

• 'current working directory'
• 'workspace directory' (or another name)
• 'LSP workspace directory' (or another name)

I am confused myself.

[EpocSquadron]

I usually refer to it as "project root", which jives with the roots language config key.

[David-Else]

pwd shows current working directory, how do we display `project root' directory?