add tree-sitter-git-diff #1373
Merged
add tree-sitter-git-diff #1373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whoops looks like there might still be a bug or two to sort out. I'll turn this into a draft until I figure this one out 🤔 |
the-mikedavis
added a commit
to the-mikedavis/helix
that referenced
this pull request
Dec 26, 2021
This ensures that children nodes of $.message are included in the injection, such as $.user or issue/pr numbers. Without this change, diffs containing '#' or '@' characters can trip up the injection and be parsed separately. See helix-editor#1373 (comment)
|
Ah actually it was a pretty small change, just needed to ensure that |
the-mikedavis
added a commit
to the-mikedavis/helix
that referenced
this pull request
Dec 26, 2021
This ensures that children nodes of $.message are included in the injection, such as $.user or issue/pr numbers. Without this change, diffs containing '#' or '@' characters can trip up the injection and be parsed separately. See helix-editor#1373 (comment)
pickfire
reviewed
Dec 26, 2021
This ensures that children nodes of $.message are included in the injection, such as $.user or issue/pr numbers. Without this change, diffs containing '#' or '@' characters can trip up the injection and be parsed separately. See helix-editor#1373 (comment)
the-mikedavis
force-pushed
the
md-tree-sitter-gitdiff
branch
from
8b29a2a
to
956397c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
primarily meant to be used in verbose commit diffs with the injections:
but I also added config for it to be used on
*.difffiles.There was a fun bug to hunt down in the grammar that prevented me from including it on #1338 (see #1338 (comment)), but I fixed that in this commit: the-mikedavis/tree-sitter-git-commit@066e395 (actually, the one in the screenshot above ^^), and now the injections seem to be working really well 🎉